I've Really Felt a Lot While Doing Code Reviews

When doing code reviews, some reviews sound like attacks rather than criticism. Even a single phrase like "Why does this work?" depends on how you phrase it.

Most of the time, people say this because they don't understand the design. So you should explain the reasoning first, but the problem is everyone skips that and just throws out the conclusion.

These days, when I write reviews, I try to always attach one line explaining why. It's a hassle, but this seems to be the easier path for both sides.

by 취준생김씨746

6 answers